]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Don't press and release keyval if it's a modifier key
authorJonas Dreßler <verdre@v0yd.nl>
Sun, 17 Nov 2024 18:16:58 +0000 (19:16 +0100)
committerJonas Dreßler <verdre@v0yd.nl>
Tue, 19 Nov 2024 19:23:25 +0000 (20:23 +0100)
commitcae8b745cab97056d7fee9aa30053817f44f53ad
tree28f423e2888fba1fa21609b1552bd3923a972607
parent91ffc4c06bbb0e4c8a5df76642c8576b61fbde9e
keyboard: Don't press and release keyval if it's a modifier key

Looks like we currently do the press-and-release dance for keys that specify
both a keyval and the "modifier" action. So when pressing CTRL in the
extended OSK, not only is the CTRL modifier set together with the next key
pressed, but the actual CTRL keyval quickly gets pressed and released,
similar to how we'd do it for the TAB key.

This seems unintentional, as the press-and-release behavior should probably
be specific to keys like TAB, and not apply to modifier keys, so limit that
behavior to only keys without an action specified.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3286>
js/ui/keyboard.js